Deploy RC 241 to Production#7585
Merged
mitchellhenke merged 18 commits intostages/prodfrom Jan 5, 2023
Merged
Conversation
* Email user when OK'ing their ThreatMetrix status When operators manually OK a user's ThreatMetrix status, send the "You verified your identity" email. changelog: Internal, ThreatMetrix, Email when OK'ing user's ThreatMetrix status For LG-8392 * s/disavowal_token/build_disavowal_token/ * linty mclinterson
…x is not required to verify (#7567) When Threatmetrix is not required for verification we should not require it for verification after success GPO OTP submisison. This commit fixes a bug where a ThreatMetrix pass was required to receive an active profile after a successful GPO code entry regardless of whether the Threatmetrix requirement was active. [skip changelog]
* Update Rubocop [skip changelog] * update rspec * Rubocop updates * update erb_lint * update bullet * update bootsnap * add brakeman ignore * fix spec
- Remove more intermediate methods - Inline a bunch - Spec cleanup * Fix regression in verified_attributes * Remove method name that was a lie and inline [skip changelog]
* Remove fetch stubbing in AddressSearch spec See: https://github.com/18F/identity-idp/pull/7538/files#r1060682580 [skip changelog] * Another one
changelog: Internal, Components, Add One Time Code Input component to local development previews
* changelog: Upcoming Features, In-Person Proofing, return all pilot locations if there’s a failure * Flag locations if they are static pilot locations; use Rails.logger * Remove check on distance as this is no longer accurate
…form (#7570) * add failing spec * Include translation helper in FormEmailValidator changelog: Bug Fixes, Reset Password, Fix 500 error when translating invalid domain error message
This arg used to be used to determine if ThreatMetrix should be used. This was in place because ThreatMetrix was only active for some service providers. A recent change made Threatmetrix active for all service providers. This argument was left in place with a `nil` default to prevent ArgumentErrors when the workers were running old and new code during deployment. Now that the code that used this argument is not running in any deployed environment the argument can be safely removed. [skip changelog]
* LG-8489: Improve YAML normalization error tolerance changelog: Internal, Build Tooling, Improve YAML normalization error tolerance * Use top-level await * Add YAML normalization to lintfix Make target * Restore parallelization See: https://github.com/18F/identity-idp/pull/7573/files#r1061615298
* Link to the handbook from README and CONTRIBUTING files * [skip changelog]
* LG-8389 - Log deactivation reason [skip changelog] * Lint and broken spec. * Add deactivation_reason to personal key submitted event * Add deactivation_reason to docs For idv_review_complete and idv_final * Use have_logged_event matcher * Log review complete + final resolution events w/ deactivation_reason * Update specs Co-authored-by: Matt Hinz <matt.hinz@gsa.gov>
…imple_form (#7539) * Disable automatically generating hints, placeholders and labels for simple_form changelog: Internal, Forms, Disable automatically generating hints and placeholders and labels for simple_form * additional optional label configuration
**Why**: breaks documentation [skip changelog]
* LG-8185 IDV verification submitted event when timeout changelog: Internal, Attempts API, Track event when timeout
[skip changelog] Removed the updates to ProofingComponent in the rake task for activating or deactivating a user's profile who is under threatmetrix review.
mitchellhenke
requested review from
aduth,
allthesignals,
jc-gsa,
jmax-gsa,
jmhooper,
jskinne3,
matthinz,
olatifflexion,
theabrad and
zachmargolis
aduth
approved these changes
Jan 5, 2023
Contributor
|
If we could enable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal
Upcoming Features