Update rubocop, brakeman, rspec, erb_lint, bullet, bootsnap gems#7569
Merged
mitchellhenke merged 8 commits intomainfrom Jan 3, 2023
Merged
Update rubocop, brakeman, rspec, erb_lint, bullet, bootsnap gems#7569mitchellhenke merged 8 commits intomainfrom
mitchellhenke merged 8 commits intomainfrom
Conversation
added 6 commits
January 3, 2023 11:46
mitchellhenke
commented
Jan 3, 2023
| suggestion: 'Rename classes that are known to be hidden by the Hush plugin' | ||
| SpaceAroundErbTag: | ||
| enabled: true | ||
| CommentSyntax: |
Contributor
Author
There was a problem hiding this comment.
This adds a check to prevent incorrect comment tags in ERB (examples borrowed from the erb_lint repository):
<%# erb comment here %>
<%= # bad erb comment here %>
<%
# apparently this comment syntax is valid?
%>
<% # very; bad erb comment here %>
added 2 commits
January 3, 2023 12:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Just a small update to use more recent gems