Remove some indirection in IdentityLinker#7420
Conversation
app/services/identity_linker.rb
Outdated
There was a problem hiding this comment.
I had two motivations here:
- rename to clarify that this is about
verified_attributes(since there were like five_attributesmethods and that wasn't clear - I don't like the pattern of re-assigning the
verified_attributesargument and figured it was easier to inline and splat
n1zyy
left a comment
n1zyy
left a comment
There was a problem hiding this comment.
I like this change. The existing code was a little bit hard to follow and this cleans it up nicely.
I think this is potentially more logically related to the (not yet written) next PR in the series, but I'm game to merge it here since it cleans things up.
There was a problem hiding this comment.
Was this just a typo in the example name? o_O
There was a problem hiding this comment.
yes as far as I could tell
We can merge this as a fast-follow to your PR, so to keep each diff small |
- Remove more intermediate methods - Inline a bunch - Spec cleanup
zachmargolis
force-pushed
the
margolis-identity-linker-cleanup
branch
from
bb179dd to
2a0064d
Compare
zachmargolis
changed the base branch from
mattw/LG-8058_default_scope
to
main
|
I'm updating this branch to go directly to |
3 participants
Small proposed change related to #7418 (or possibly the next PR after, where we'll to conditionally createServiceProviderIdentityrows but with fewer attributes)Originally started as a patch to #7418, but that may not land, and I think these changes would be good regardless