Fix 500 error when submitting invalid email domain in reset password form#7570
Merged
mitchellhenke merged 2 commits intomainfrom Jan 3, 2023
Merged
Conversation
added 2 commits
January 3, 2023 14:44
changelog: Bug Fixes, Reset Password, Fix 500 error when translating invalid domain error message
mitchellhenke
changed the title
zachmargolis
approved these changes
Jan 3, 2023
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM good catch. should we patch this in to prod?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
The
FormEmailValidatormodule does not include translation helpers, and raises an exception when calling thettranslation helper method (NewRelic error).This was missed when the validation was added in #7380 because the
RegisterUserEmailFormincludes the translation helper itself, thePasswordResetEmailFormdoes not, and no test was written against it.