Disable automatically generating hints, placeholders and labels for simple_form

[mitchellhenke]

🛠 Summary of changes

A follow up to #7537 that is intended to address the root problem of implicitly generating labels. This is in part relying on existing tests to find issues like those in #7537. I'm not sure if we want to add some defensiveness by requiring the label: parameter on things like ValidatedFieldComponent.

The secondary benefit to this is a minor performance improvement when using simple_form_for. simple_form attempts to find translations for each hint, placeholder and label it may create which results in some additional work. Preliminary testing shows a 2-3% reduction in memory allocation for GET /. I'm not expecting a noticeable effect in response time.

[zachmargolis]

LGTM

[aduth]

LGTM 👍

I noticed that the label_text in the legend wrapper appears to add its own label as well:

identity-idp/config/initializers/simple_form.rb

Lines 61 to 63 in 869886f

	b.wrapper :legend, tag: 'legend', class: legend_class do |ba|
	ba.use :label_text
	end

For example, commenting this line would cause a default label to be shown:

identity-idp/app/views/shared/_email_languages.html.erb

Line 10 in 869886f

label: t('forms.registration.labels.email_language'),

Should that be optional as well?

Also, I see it's documented in the SimpleForm documentation, but I'm not sure what default hints and placeholders were actually doing, if anything?

[mitchellhenke]

LGTM 👍

I noticed that the label_text in the legend wrapper appears to add its own label as well:

identity-idp/config/initializers/simple_form.rb

Lines 61 to 63 in 869886f

	b.wrapper :legend, tag: 'legend', class: legend_class do |ba|
	ba.use :label_text
	end

For example, commenting this line would cause a default label to be shown:

identity-idp/app/views/shared/_email_languages.html.erb

Line 10 in 869886f

label: t('forms.registration.labels.email_language'),

Should that be optional as well?

Great catch, yes, updated.

Also, I see it's documented in the SimpleForm documentation, but I'm not sure what default hints and placeholders were actually doing, if anything?

I'm not sure, it's hard to test when it would come into effect, so I may have over-applied it.