Merged
Conversation
jmax-gsa
force-pushed
the
LG-8389-log-profile-deactivation-reason
branch
from
8faa966 to
0cdd377
Compare
matthinz
force-pushed
the
LG-8389-log-profile-deactivation-reason
branch
3 times, most recently
from
8b4cf14 to
11f08f3
Compare
zachmargolis
approved these changes
Jan 3, 2023
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM! just small style nits. I feel more strongly about the YARD suggestions than the indentation
[skip changelog]
For idv_review_complete and idv_final
matthinz
force-pushed
the
LG-8389-log-profile-deactivation-reason
branch
from
11f08f3 to
7203c3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-8389