Merged
Conversation
changelog: Internal, Logging, Instrument HTTP requests for In-Person-Proofing
[skip changelog]
[skip changelog]
[skip changelog]
…tion (#6693) * add failing spec * Fix unhandled error when attempting update of invalid phone configuration changelog: Bug Fixes, Account Management, Fix unhandled error when attempting update of invalid phone configuration
* LG-6978 : Implement Confirm email event changelog: Internal, Attempts API, Track additional events * Update app/services/irs_attempts_api/tracker_events.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* LG-6984 TOTP Enroll Submit & stub_attempts_tracker changelog: Internal, Attempts API, Track additional events
* Test analytics logs GPO letter requested * Rename new property * Support path to request letter instead of verify phone * Create helper method for gpo step * Test analytics events * Add expected parameter * Pass `enqueued_at` to `track_event` * Modify formatting * Remove unused event * Move test to services analytics spec * Use fake analytics in test * Rename analytics object Changelog: Improvements (LG-6793) categories: - Improvements * Add comment on new method * Rename analytics object changelog: Internal, Logging, Log the time an address verification letter is enqueued * Add comment on new method * Log letter requested when profile is initiated * Log enqueued at in 2 places * Camel case data type Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Support extra parameters * Add trailing comma * Inject current time as a default value * Capture current time once for testing later note: my understanding that these hash values are currently ignored in this spec * Replace now variable with freeze time Around block freezes time so Time.zone.now doesn't drift between initializing and testing Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
**Why**: Improved performance, both at build time and runtime. changelog: Internal, Build, Improve stylesheet build performance
* Add coverage for DocAuthController#redirect_if_pending_in_person_enrollment * Add coverage for SessionsController#cancel_in_person_enrollment_if_exists * Add coverage for User#establshing_in_person_enrollment * changelog: Upcoming Features, In-person proofing, Add support for hybrid document capture in-person opt-in * Initialize user argument as nil when not used Avoid creating a new user instance * Create profile specific for establishing enrollment Avoid duplicate use resulting in foreign key constraint violation
* LG-7304 Add Attempts API Logout Initiated tracking changelog: Internal, Attempts API, Track additional events
Move code to a different location in our codebase so that it has a more appropriate namespace. [skip changelog]
…6687) * Support optional dashes in SSN failure scenario Match expected live vendor behavior https://github.com/18F/identity-idp/blob/abd5e7b22a7b67ab25c2f88c356dc0e9fd8048be/app/services/proofing/lexis_nexis/instant_verify/verification_request.rb#L22 * LG-6927: Omit in-person troubleshooting option when already in flow **Why**: So that the user doesn't get stuck in a loop of attempting to troubleshoot by verifying in-person. changelog: Upcoming Features, In-person proofing, Hide in-person troubleshooting option while already in flow * Sync specs to updated logic No longer using request path * Remove in-person troubleshooting from everywhere other than doc auth See: - #6687 (comment) - #6687 (comment) * Update spec assertions for removed logic * Simplify inPersonURL type signature `null` and `undefined` are both used as "empty" values, prefer one. Also simplifies defaulting behavior in document-capture, since it would be assumed to be undefined when absent, previously coerced to null.
* Collapse profile creation to single method **Why**: So that deactivation_reason can be assigned in initial creation of the profile, rather than as an immediate follow-on transaction. changelog: Internal, Optimization, Optimize identity verification profile database creation * Fix spec failure for GPO address verification 1. Applicant is now assigned in `before` block of the top-level method `describe` 2. Avoid calling create_profile_from_applicant_with_password twice * Add active as required kwarg for save_profile So activation is centralized to the ProfileMaker and callsites must make an explicit choice #6681 (comment) * Add required kwarg to PersonalKeyController stub
* Log the enqueued_at date when a user enters a code This will allow us to bin letter sent and code entered events based on when the letter was sent changelog: Improvements, Identity Verification, Internal logging for tracking letter confirmations was added.
* Verify establishing enrollment for in-person flow **Why**: Since a user will need to select a location as part of establishing an enrollment before proceeding with the in-person flow. changelog: Upcoming Features, In-person proofing, Verify establishing enrollment for in-person flow * Invalidate applicant when assigning PII * Refactor verify step PII methods as abstract Avoid ambiguity between the two implementations * Avoid reinitializing IdV session when blank Seems to cause issues with replacing an existing session values, leading to session being empty at points-in-time where it's not expected to be, purely by referencing idv_session (e.g. in DocAuthController#redirect_if_session_applicant) * Update specs after rebase for #6687 * Rename before_action to describe intent, not implementation See: #6703 (comment)
* LG-6977 Add Attempts API Email Submitted tracking changelog: Internal, Attempts API, Track additional events * LG-6977 updating feedback for email submit event tracking
changelog: Bug Fixes, Logging, Fix duplicate event logging for MFA Setup Complete event
* add text for personal key * add text to password reset form * add test for new text * correct text changelog: Improvements, password key, show information about password key on password reset Co-authored-by: Jessica Dembe <jmdembe@gmail>
This change allows us to sort between users requesting a new letter and users who are requesting their first letter. This allows us to group users requesting letters into cohorts based on when they requested their first letter by filtering out resends. changelog: Improvements, Identity Verification, Internal logging for tracking whether a letter is resent was addedwq.
Track unsuccessful IdV password confirmation attempts This change will allow us to track how much toil there is at this step changelog: Improvements, Identity Verification, Internal logging for tracking toil on the password confirm step.
* LG-7058 | IrsAttemptsApi::Tracker sets up base parameters changelog: Internal: Attempts API: Establish base event attributes
changelog: Internal, Attempts API, Track additional events
* Install mailcatcher via Gemfile * Step 4 runs `rake db:create` so Step 3 is redundant * Updating README with macOS openssl instructions -- Notes For mailcatcher to install correctly on macOS (M1 and Intel), we need to install it via brew and link to the correct header location. The instructions specify how to do that before installing. * Target openssl v.3 * Restore manual install of mailcatcher for now include note for openssl issue we resolved * Switchin required openssl version to 1.1 -- Notes We have two concurrent problems with openssl: First, on M1 macs, openssl's libraries are in a different location. Second -- and more relevant to this particular commit -- eventmachine is not able to properly use its C extensions with openssl@1.3, which is what homebrew will install by default. This will fail silently during the setup/install phase and only become apparent when attempting to run the application. The solution is to strictly use openssl@1.1 for the moment. * Ensuring we build js before testing and updating README -- What 1. `yarn build` was not being called before tests in the Makefile. So if you pulled down the repository, ran `make setup` and followed all the instructions in the readme, tests would still fail because at no point in that process do js bundles get built. I have added this to the relevant Makefile actions 2. The README had a typo about openssl1.3 when we require 1.1 changelog: Improvements, Documentation, Updating onboarding documentation (LG-6972) Co-authored-by: darth-cheney <eric.gade@gmail.com>
stevegsa
approved these changes
Aug 9, 2022
aduth
approved these changes
Aug 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements
Bug Fixes
Internal
Upcoming Features