LG-6977 : Implement email submitted event#6697
Merged
olatifflexion merged 2 commits intomainfrom Aug 9, 2022
Merged
Conversation
changelog: Internal, Attempts API, Track additional events
olatifflexion
force-pushed
the
olatif/LG-6977-email-submitted-event
branch
from
39387a4 to
c56db71
Compare
n1zyy
reviewed
Aug 5, 2022
Contributor
n1zyy
left a comment
n1zyy
left a comment
There was a problem hiding this comment.
I'm not sure about the fake_analytics.rb change, but the rest of this looks excellent. Let me know if I'm just missing some context, but it seems like it'd be easier to not mess with the analytics bits.
n1zyy
approved these changes
Aug 8, 2022
Contributor
n1zyy
left a comment
n1zyy
left a comment
There was a problem hiding this comment.
We may want to wait for @zachmargolis's signoff as well, but I like how this came out! 👍
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: Internal, Attempts API, Track additional events