Merged
Conversation
gangelo
reviewed
Aug 3, 2022
Contributor
There was a problem hiding this comment.
That space supposed to be there? I can’t tell I’m doing this on my phone.
Contributor
Author
There was a problem hiding this comment.
Yep, I think it's from the indent within the freeze_time block
[skip changelog]
mitchellhenke
force-pushed
the
mitchellhenke/fix-flaky-va-api-spec
branch
from
eae9ae8 to
4058140
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like the expiration time encoded in the token is causing failures since it doesn't always match exactly:
{ "inherited_proofing_auth": "mocked-auth-code-for-testing", "exp": 1659640373 }{ "inherited_proofing_auth": "mocked-auth-code-for-testing", "exp": 1659640374 }This PR freezes the time to hopefully help it be a bit more reliable.