Fix duplicate event logging for MFA Setup Complete event#6706
Merged
mitchellhenke merged 1 commit intomainfrom Aug 9, 2022
Merged
Fix duplicate event logging for MFA Setup Complete event#6706mitchellhenke merged 1 commit intomainfrom
mitchellhenke merged 1 commit intomainfrom
Conversation
changelog: Bug Fixes, Logging, Fix duplicate event logging for MFA Setup Complete event
mitchellhenke
force-pushed
the
mitchellhenke/fix-duplicate-mfa-complete
branch
from
132170e to
696b8b7
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
next_setup_pathis called after any MFA setup, which includes MFA setups after account registration, and this event was only intended to be logged during registration.To fix that, this event should only be logged if there are MFA selections (which only exist during account registration).