Fix unhandled error when attempting update of invalid phone configuration#6693
Merged
mitchellhenke merged 2 commits intomainfrom Aug 4, 2022
Merged
Fix unhandled error when attempting update of invalid phone configuration#6693mitchellhenke merged 2 commits intomainfrom
mitchellhenke merged 2 commits intomainfrom
Conversation
solipet
approved these changes
Aug 4, 2022
Contributor
solipet
left a comment
solipet
left a comment
There was a problem hiding this comment.
Looks good. I might have written it as a guard, or like:
if attributes[:phone_id].present?
update_phone_configuration unless phone_configuration.nil?
else
…tion changelog: Bug Fixes, Account Management, Fix unhandled error when attempting update of invalid phone configuration
mitchellhenke
force-pushed
the
mitchellhenke/fix-telephone-update-500
branch
from
537a105 to
7f3a6a2
Compare
Contributor
Author
That's much better, thank you (updated) 😅 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.