Instrument HTTP requests for In-Person-Proofing#6685
Merged
mitchellhenke merged 1 commit intomainfrom Aug 3, 2022
Merged
Conversation
changelog: Internal, Logging, Instrument HTTP requests for In-Person-Proofing
NavaTim
approved these changes
Aug 3, 2022
| parse_facilities( | ||
| faraday.post(url, body, headers).body, | ||
| faraday.post(url, body, headers) do |req| | ||
| req.options.context = { service_name: 'usps_facilities' } |
Contributor
There was a problem hiding this comment.
You may want to verify in the tests that these blocks set the context.
aduth
approved these changes
Aug 3, 2022
mitchellhenke
pushed a commit
that referenced
this pull request
Aug 3, 2022
changelog: Internal, Logging, Instrument HTTP requests for In-Person-Proofing
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that we can have better visibility into the volume, success rate, and timing of the requests
(documentation for this added in #6686)