Merged
Conversation
**Why**: Because they're never actually presented to the user, who will instead see the message derived from the failing response.
* LG-4956: translations for possible error messages for activemodel validation * LG-4956: Include additional translations for activemodel validations * LG-4956: normalize yaml
- Minimize chances of accidental logging by using redacted struct
- Make columns nullable so we can stop writing - Remove unique index so we can stop writing
…5577) * LG-4870: Configure Acuant SDK path for JavaScript WebSDK resources **Why**: Simplify to remove symlinks which exist only to support loading Acuant SDK relatively from subpaths. Instead, configure Acuant to point directly to the canonical source directory. * Revert, support both new and old Acuant static paths **Why**: To avoid issue with mid-deploy session requests
**Why**: Because none of these classes are currently in use.
* fix error in job log subscriber * add spec
Fixes error in AWS CLI
**Why**: Clean up log output in specs
**Why**: So that it's easier to debug the root cause of a console log, which may use format arguments to describe the callsite.
mitchellhenke
approved these changes
Nov 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.