Prepare to drop encrypted_code columns (LG-4427)#5582
Merged
zachmargolis merged 1 commit intomainfrom Nov 4, 2021
Merged
Conversation
Contributor
zachmargolis
commented
Nov 4, 2021
zachmargolis
commented
- Make columns nullable so we can stop writing
- Remove unique index so we can stop writing
- Make columns nullable so we can stop writing - Remove unique index so we can stop writing
zachmargolis
requested review from
jmhooper,
kevindayton,
mitchellhenke and
stevegsa
mitchellhenke
approved these changes
Nov 4, 2021
Contributor
mitchellhenke
left a comment
mitchellhenke
left a comment
There was a problem hiding this comment.
Can we also make these ignored columns to drop them later?
Contributor
Author
Yup! That's my next PR: #5583 Unfortunately because of the unique index, and non-null constraints, we have to write some value to those columns right now. This PR loosens those constraints so the next one can ignore, and the next after that will drop finally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.