Add configuration to turn off agreements data seeding if desired#5581
Merged
Add configuration to turn off agreements data seeding if desired#5581
Conversation
orenyk
changed the title
zachmargolis
approved these changes
Nov 4, 2021
config/application.yml.default
Outdated
Contributor
There was a problem hiding this comment.
Do we need a top-level key as the default value for dev, test, etc?
Contributor
Author
There was a problem hiding this comment.
Do you mean because nil defaults to false? Or something else?
Contributor
There was a problem hiding this comment.
I got confused about where this was in the structure of the file.
I think at the top-level it should be true
and then we should override it in the production: block to be false
and then like you said, override it via the value in S3 again in prod
Contributor
Author
There was a problem hiding this comment.
Got it, yeah that makes sense. I'll make that update and hopefully that resolves the failing specs.
orenyk
force-pushed
the
oyk-limited-agreements-seed
branch
from
5198c50 to
e7ff138
Compare
russbeye
approved these changes
Nov 4, 2021
russbeye
left a comment
russbeye
left a comment
There was a problem hiding this comment.
Real nice! What a catch from @zachmargolis btw!
orenyk
force-pushed
the
oyk-limited-agreements-seed
branch
from
e7ff138 to
8a96621
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: https://gsa-tts.slack.com/archives/C01SU3NB9T3/p1636035938073500
We need to make sure we turn this setting on in production
application.ymlbefore deploying.