LG-4870: Configure Acuant SDK path for JavaScript WebSDK resources#5577
Merged
LG-4870: Configure Acuant SDK path for JavaScript WebSDK resources#5577
Conversation
**Why**: Simplify to remove symlinks which exist only to support loading Acuant SDK relatively from subpaths. Instead, configure Acuant to point directly to the canonical source directory.
Contributor
|
How do you feel about breaking this into two separate PRs? So that old boxes don't point at potentially broken links during the ~15min deploy?
|
Contributor
Author
Yep, good thinking. Will update to split off a follow-on pull request to merge in a separate deploy. |
**Why**: To avoid issue with mid-deploy session requests
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Simplify to remove symlinks which exist only to support loading Acuant SDK relatively from subpaths. Instead, configure Acuant to point directly to the canonical source directory.
Previously, we assumed that Acuant would always try to load its dependent resources (WASM worker, etc) relative to the current path. This required us to implement complex routing to support non-English and hybrid flows.
It turns out that this is a simple configuration option that we overlooked:
acuantConfig = { path: "..." }This will be useful to help simplify the upgrade to Acuant SDK v11.5.0 (LG-4392).
I may or may not have had this branch sitting around on my computer since July. I assume it's still valid.