Remove unused document capture notice text

[aduth]

Why: Because they're never actually presented to the user, who will instead see the message derived from the failing response.

Also helps for a few points of general cleanup:

• bold is a BassCSS class and is deprecated in favor of design system.
• Per Refactor Alert partial to ViewComponent #5565 (comment), these sorts of notice content with embedded HTML may need to be opted-in to html_safe, so this eliminates one point of update.

This logic is only used for the no-JavaScript document capture. In practice, what happens is that the same error message which would be presented in the React application is presented to no-JavaScript.

Example:

If you follow the flow of logic, you can see that the failure method does capture this as "extra", but that extra is not used for presenting a notice, and in-fact doesn't appear to be used for much of anything at all:

identity-idp/app/services/flow/base_step.rb

Lines 53 to 58 in 759408a

	def failure(message, extra = nil)
	flow_session[:error_message] = message
	form_response_params = { success: false, errors: { message: message } }
	form_response_params[:extra] = extra unless extra.nil?
	FormResponse.new(**form_response_params)
	end

identity-idp/app/services/flow/flow_state_machine.rb

Lines 28 to 34 in 759408a

	register_update_step(step, result)
	if flow.json
	render json: flow.json, status: flow.http_status
	return
	end
	flow_finish and return unless next_step
	render_update(step, result)

The actual error message is pulled from the flow_session[:error_message]:

identity-idp/app/views/idv/doc_auth/_error_messages.html.erb

Line 6 in 759408a

<%= flow_session[:error_message] %>

Originally: #3929

cc @anniehirshman-gsa in case you're aware of these messages being intended to be shown anywhere.

[zachmargolis]

LGTM

[solipet]

w00t!

[anniehirshman-gsa]

Beautiful ✨