Merged
Conversation
zachmargolis
approved these changes
Nov 5, 2021
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
ooof, any spec coverage we can add for this?
mitchellhenke
force-pushed
the
mitchellhenke/fix-error-in-log-subscriber
branch
from
70a689a to
2f96dcf
Compare
Contributor
Author
Testing a job subscriber is still weird, but added a couple specs to hopefully cover the bare minimum of not crashing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was looking at worker logs and noticed:
This PR should fix that