Deploy rc-2017-08-21 to staging#1624
Merged
jmhooper merged 38 commits intostages/stagingfrom Aug 17, 2017
Merged
Conversation
**Why**: - Current implementation looks at all environment variables, both those associated with application configuration and those that don't apply (e.g., IMSETTINGS_INTEGRATE_DESKTOP). Non-configuration settings with bad values will cause warnings. This change aims to target validation to only the configuration values. **How**: - Select keys (environment variable names) that have a 2nd definition prefixed with "FIGARO_" - these are the key/value pairs associated with application configuration. - Check values case insensitive, ignoring white space. - Add test cases.
Fixes an issue that was redirecting users to /verify instead of /account after clicking the "Send another letter" button.
**Why**: Adding a new field broke the script
Fix load testing script for new phone form
**Why**: So the user can select an OTP delivery preference for their new phone number. Merge 2FA setup and update user phone form **Why**: With the addition of the OTP delivery preference option, both forms are essentially identical and can be served by a single class. Use submitted phone if phone is invalid **Why**: The phone number formatting and validations mutates the phone number on the user phone form. This can cause weird errors, especially when the country code doesn't match the phone number. For example, `+212-123-456-7890` becomes `+212-212-123-456-7890` after formatting. This commit uses the submitted value instead of the formatted value when the phone is invalid to prevent this.
…ction Add OTP delivery preference to update user phone form
**Why**: Stay on-brand
Update loading spinner
Fix verification by mail redirect logic
Provide better 'bad key' value error message
**Why**: It keeps HTML tags out of the translation pipeline. Sending HTML through translations is error-prone so this just focuses on the copy.
Update digital analytics program i18n
**Why**: Additional flexibility for load testing
Allow pre-filling OTP in dev environment
**Why**: To make it easier to remember that LOA3 features should always be tested with both SAML and OIDC This is a small PR to show what I have in mind for refactoring these tests and to make sure we have consistent coverage between SAML and OIDC.
Use shared examples for OIDC and SAML LOA3 specs
**Why**: It is confusing for users to verify their phone number after entering confirming their profile by entering their password. This commit changes the order so the user verifies their phone immediately after entering it Add spec for session#complete_session **Why**: While working on the verify by phone flow for the IdV process, I want to add a test to make sure that I don't create a situation where a profile can be activated without a confirmed phone number of record. Link to cancel path for idv phone OTP cancel **Why**: When a user cancels during identity verification, we don't want to sign them out. They were being signed out because we were sharing code with the authentication 2FA flow. Check in review controller if phone confirmed **Why**: If the user has not confirmed their phone during the IdV flow, we want to redirect to the phone confirmation instead of allowing them to continue with the creation of their profile.
Reorder phone confirmation and review page
**Why**: To enable rollout
**Why**: To continue consolidating SAML and OIDC specs
Move USPS verification specs to shared example
**Why**: We want tests for the case where the user selects USPS verification for both the SAML and OIDC protocols.
…xamples Move USPS verification selection to shared example
Add CBP OARS prod config
Use style-guide to import fonts and favicons
**Why**: Provide the user helpful instructions explaining that the idv flow is finished until they receive a letter with their OTP. Also, gives them the ability to return to the SP, or if we don't have a URL for the SP, their account page.
Add come back later page
**Why**: Similarly to strong parameters, it's a best practice to use a whitelist approach as opposed to excluding unwanted parameters.
Use a whitelist approach for URL parameters
**Why**: Missing colon in URI scheme from #1580
Update CBP OARS SP config
This needs to be configured in Chef first.
Revert "Merge pull request #1582 from 18F/bh-use-style-guide"
**Why**: Only US numbers can be used as the phone number of record. This commit changes the frontend JS so that the text fields only formats US numbers and prevents the user from typing an international number. Don't use intl number for init value in IdV form **Why**: We don't allow the user to use an international number during identity verification, so we should not populate the form with an international number as the initial value
**Why**: This is a common error to encounter in deployment, and right now we get an extremely unhelpful message. There isn't even any way to tell what key file failed to load without looking at the line number in the backtrace and consulting the IDP source code. ``` OpenSSL::PKey::RSAError: Neither PUB key nor PRIV key: nested asn1 error ``` With this change, we will at least log a better message to help understand what's happening.
Disallow international numbers in IdV process
Log useful error message when failing to load key.
Contributor
|
Spec failure is OK -- this file is not actually served by our app so it won't break in IE due to CSP issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.