Disallow international numbers in IdV process#1578
Merged
Conversation
Contributor
Author
|
This is waiting on messaging for international numbers described in https://github.com/18F/identity-private/issues/2261 |
jmhooper
changed the title
Contributor
Author
|
Unblocked. Thank you @jeanninehunter and @mkhandekar |
jmhooper
changed the title
Contributor
Author
|
Just noticed Travis didn't like this one. Going back to WIP |
jmhooper
changed the title
jmhooper
added
status - work in progress
status - ready for review
and removed
status - ready for review
status - work in progress
labels
jmhooper
changed the title
Contributor
Author
|
Fixed the bug that broke this in CI. Marked ready for review again. |
**Why**: Only US numbers can be used as the phone number of record. This commit changes the frontend JS so that the text fields only formats US numbers and prevents the user from typing an international number. Don't use intl number for init value in IdV form **Why**: We don't allow the user to use an international number during identity verification, so we should not populate the form with an international number as the initial value
jmhooper
force-pushed
the
jmhooper-idv-flow-phone-formatter
branch
from
ac7aa81 to
aeca825
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't use international number for initial value in IdV phone form
Why: We don't allow the user to use an international number during identity verification, so we should not populate the form with an international number as the initial value
Format phone number of record as a US number
Why: Only US numbers can be used as the phone number of record. This commit changes the frontend JS so that the text fields only formats US numbers and prevents the user from typing an international number.