Move USPS verification selection to shared example#1583
Merged
Conversation
jmhooper
commented
Aug 1, 2017
Contributor
Author
There was a problem hiding this comment.
This method and the next are borrowed from #1581
jmhooper
commented
Aug 1, 2017
Contributor
Author
There was a problem hiding this comment.
This test is almost completely copy/pasted from the original one except for this line through 37. I added those to check that we match the initial state setup in #1581
jmhooper
commented
Aug 1, 2017
Contributor
Author
There was a problem hiding this comment.
Did this so I could do the following in the tests:
user = register_user...instead of...
email = 'asdf@test.com'
register_user(email)
user = User.find_with_email(email)
Contributor
|
Looks good. Wanna rebase with master to pick up the changes in my PR (renamed methods)? |
jmhooper
force-pushed
the
jmhooper-usps-verification-shared-examples
branch
from
ac9502e to
a4de41e
Compare
Contributor
Author
|
Rebased |
jmhooper
commented
Aug 2, 2017
Contributor
Author
There was a problem hiding this comment.
I'd like to rename this. Having usps_address_confirmation.rb next to usps_verification.rb is a little bit confusing.
Contributor
Author
|
Renamed the file that holds the new shared examples. PTAL |
**Why**: We want tests for the case where the user selects USPS verification for both the SAML and OIDC protocols.
jmhooper
force-pushed
the
jmhooper-usps-verification-shared-examples
branch
from
c02f637 to
001586e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: We want tests for the case where the user selects USPS
verification for both the SAML and OIDC protocols.