Fix verification by mail redirect logic

[gemfarmer]

For issue https://github.com/18F/identity-private/issues/1890

Fixes an issue that was redirecting users to /verify instead of /account after clicking the "Send another letter" button.

There are now two tests to check the verification letter flow. One if the user doesn't log out before entering their confirmation letter (this probably will never happen in real life) and one if they do log out.

[monfresh]

Code Climate says this is not tested. Can you double check that the specs are performing the correct steps? I would expect at least one of those specs (if not both) to have an expectation that the user ends up on the account_path.

[gemfarmer]

hmmm. Yeah, I'll check.

[gemfarmer]

the flow just wasn't completed. I updated the specs and Code Climate should be happy now

[monfresh]

I know this was like this before this PR, but to make sure we're testing things exactly like the user would experience, can we change sign_in_live_with_2fa(user) to this instead?

click_link t('links.sign_in')
fill_in_credentials_and_submit(user.email, user.password)
click_submit_default

The difference is that the latter preserves the request_id in the URL, whereas the former doesn't, and we have logic in the app that does different things depending on whether or not the request_id is present.

[monfresh]

We'll also need allow(FeatureManagement).to receive(:prefill_otp_codes?).and_return(true) if the test doesn't already use that.

[gemfarmer]

👍

It looks like we are prefilling before each test, so I won't add anything new on that front!

[gemfarmer]

But wait, isn't the point of reusing methods like sign_in_live_with_2fa(user) to avoid duplication of processes that are the same? How is this different?

[monfresh]

The problem is sign_in_live_with_2fa(user) visits new_user_session_path explicitly, instead of clicking the "Sign In" button, which drops the request_id from the URL. To avoid duplication, we can create a new helper method.

[gemfarmer]

@monfresh made those final changes. Ready for review! I'm headed out on vacation, so merge if you think it is ready :)

[monfresh]

LGTM