Move USPS verification specs to shared example#1581
Conversation
There was a problem hiding this comment.
I just realized this does not involve account creation. I will move to a different folder.
monfresh
force-pushed
the
mb-fix-oidc-controller
branch
from
cc6bfd7 to
0092303
Compare
There was a problem hiding this comment.
should we make this an elsif? might get rid of the rubocop warning above?
There was a problem hiding this comment.
should this be .to eq(1) instead of be ?
There was a problem hiding this comment.
Sure. It was like that before but I can change it.
There was a problem hiding this comment.
This is pretty similar to the code with have in the account creation shared example. It'd be nice to move all of this into an idv helper
There was a problem hiding this comment.
I thought we were planning on having these live under the account creation feature? I guess this is kind of a gray area since the account is already created, but it seems like it is still a part of that flow?
There was a problem hiding this comment.
I think for this case, it makes sense to have a separate USPS verification folder since the user will need to wait several days to receive the code before being able to finish, and within this feature, there are several scenarios to consider, such as entering the correct vs wrong code, asking for a new letter, exceeding the max allowed amount of letters, etc.
There was a problem hiding this comment.
Also, I added a new scenario for the context where the user is signing back in directly (i.e. not coming from an SP). PTAL.
spec/support/features/idv_helper.rb
Outdated
There was a problem hiding this comment.
Thoughts on finding a way to rename this so it is clear it's specific to OIDC? I'd also think visit_idp_from_sp_with_loa3 fits better on the method that is currently named perform_loa3_request_from_sp.
There was a problem hiding this comment.
Good points. I renamed the methods here: abcd42c
jmhooper
left a comment
jmhooper
left a comment
There was a problem hiding this comment.
I had a final comment about a method name, but I'm fine either way on that
monfresh
force-pushed
the
mb-fix-oidc-controller
branch
from
abcd42c to
0728a00
Compare
**Why**: To continue consolidating SAML and OIDC specs
3 participants
Why: To continue consolidating SAML and OIDC specs