Skip to content

Revert "Merge pull request #1582 from 18F/bh-use-style-guide"#1589

Merged
hursey013 merged 1 commit intomasterfrom
bh-undo-style-guide-npm
Aug 4, 2017
Merged

Revert "Merge pull request #1582 from 18F/bh-use-style-guide"#1589
hursey013 merged 1 commit intomasterfrom
bh-undo-style-guide-npm

Conversation

@hursey013
Copy link
Contributor

@hursey013 hursey013 commented Aug 4, 2017

This change needs to be held back for now, and re-added when the change here has been made.

@hursey013 hursey013 self-assigned this Aug 4, 2017
@zachmargolis
Copy link
Contributor

Do you want to make this an actual revert commit?

git revert -m 1 $COMMIT

Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re: my "actual merge commit" comment -- I was wrong, this is a merge commit, but I expected the commit message to have a slightly different format. LGTM!

This needs to be configured in Chef first.
@hursey013 hursey013 force-pushed the bh-undo-style-guide-npm branch from a055106 to 6bce21d Compare August 4, 2017 19:09
@hursey013 hursey013 changed the title Revert importing assets from npm identity-style-guide Revert "Merge pull request #1582 from 18F/bh-use-style-guide" Aug 4, 2017
@hursey013 hursey013 merged commit 5094016 into master Aug 4, 2017
@hursey013 hursey013 deleted the bh-undo-style-guide-npm branch August 4, 2017 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants