Merged
Conversation
LG-15974: Set document_type on new enrollments *How* - This work enables writing `document_type` on the `InPersonEnrollment` model on _successful_ submission of the `StateIdForm` in the state id controller. - On "undo" or backwards navigation, which will take the applicant back to the "Pick a post office screen", the `enrollment.document_type` should set or reset to nil. - Cancelling the enrollment after successful submission of the state ID information does not clear the `document_type` field. *Why* - This allows us to pass the type of ID used to verify with USPS See: [LG-16127: Write ID type to InPersonEnrollment.document_type](https://cm-jira.usa.gov/browse/LG-16127) changelog: Internal, IPP, Write document_type when saving enrollments
* changelog: Upcoming Features, Attempts API, Adds idv-enrollment-complete event
* use address presenter to have enter or update text * add address_update_request to determine if updating address * add changelog changelog: Upcoming Features, Doc Auth, Add new address screen for passports * lint * fix specs * request.referer fix * added cancel button instead of back button for passport address flow * change redirects for back button on address page
…12133) * add DOS health check after post office selection * Changelog: Upcoming Features, In-person proofing, add second DOS health check after post office selection * include Idv::ChooseIdTypeConcern in in_person_controller * rework navigation for ipp choose id type and state id page * tweak tests in response to feedback
) * add a/b test for disabling manual document upload Co-authored-by: Malik Warren <malik.warren@gsa.gov> * add changelog changelog: Upcoming Features, Doc Auth, add a/b test for disabling manual document upload * change ab testing name to add enabled at the end * default percent to 0 --------- Co-authored-by: Malik Warren <malik.warren@gsa.gov>
* changelog: Upcoming Features, Attempts API, Updating events to address feedback
changelog: Upcoming Features, In-person proofing, Add address, ssn, and verify info to IPP passport flow
* changelog: Internal, Specs, Fixing flakey cancel specs * Updating spec * Updating wait time to 0.5 instead of 5. Tested to ensure stability * Removing explciit wait parameters to use default_max_wait_time, have_content changes still needed * Removing js from spec, added for debugging
…cation icon alt text translations (#12138)
* changelog: Upcoming Features, Attempts API, Adds forgot-password-email-sent event
* Add doc_type on enrollment for passport * Passport controller specs and trait * changelog: Upcoming Features, In-person proofing, Set document_type on InPersonEnrollment for Passports * Delete dup routes for IPP passports
changelog: Bug Fixes, Profiles, Update ssn fingerprint with normalized form See https://cm-jira.usa.gov/browse/LG-16195
mdiarra3
requested review from
eileen-nava,
gina-yamada,
mitchellhenke and
shanechesnutt-ft
jmdembe
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal
Upcoming Features