Skip to content

LG-16179 Set Document Type on InPersonEnrollment for Passports#12135

Merged
gina-yamada merged 7 commits intomainfrom
yamada/LG-16179-SetDocTypeOnInPersonEnrollmentForPassport
May 7, 2025
Merged

LG-16179 Set Document Type on InPersonEnrollment for Passports#12135
gina-yamada merged 7 commits intomainfrom
yamada/LG-16179-SetDocTypeOnInPersonEnrollmentForPassport

Conversation

@gina-yamada
Copy link
Copy Markdown
Contributor

@gina-yamada gina-yamada commented May 2, 2025

🎫 Ticket

LG-16179 Set Document Type on InPersonEnrollment for Passports

🛠 Summary of changes

  • On passport submit, set InPersonEnrollment.document_type to passport_book

📜 Testing Plan

Scenario: Global passports and In-Person Passports is enabled

  • Setup: Ensure the following environment variables are set
  in_person_proofing_enabled: true
  in_person_proofing_opt_in_enabled: true
  in_person_passports_enabled: true
  doc_auth_passports_enabled: true
  doc_auth_passports_percent: 100
  • Login through the oidc sinatra application selecting the Identity Verified level of service
  • Create a new account
  • Complete the ID-IPP flow reaching the IPP Choose your ID type page and select U.S. passport book
  • Once on the the IPP Passport view at url /verify/in_person/passport open up rails to confirm document_type on the establishing InPersonEnrollment is nil.
  • Fill out the passport form. Click Submit on the passport form.
  • Inspect document_type on the establishing InPersonEnrollment. It should say passport_book. Don't worry about validation errors on the form. You should not move on to the next step. (Code was merged in on 05/07 from another PR so you will move to the next page.) You should not see an AWS event log for Passport Submit. All are out of scope and being handled in another ticket.
  • Re-test steps above for hybrid flow. This should work because you are already back on desktop out but good to test it.

Other Scenarios:

  • If both global passports and in-person passports are not enabled you will not be able to be on the passport view to submit. You will arrive at State ID and not at Choose your ID.

put '/in_person' => 'in_person#update'
get '/in_person/choose_id_type' => 'in_person/choose_id_type#show'
put '/in_person/choose_id_type' => 'in_person/choose_id_type#update'
get '/in_person/passport' => 'in_person/passport#show'
Copy link
Copy Markdown
Contributor Author

@gina-yamada gina-yamada May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a duplicate from https://github.com/18F/identity-idp/pull/12134/files
You can see get route exists below on line 452/451

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Copy Markdown
Contributor

@shanechesnutt-ft shanechesnutt-ft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran through the tests and things look good. Nice job! 👍🏻

@gina-yamada gina-yamada merged commit af3d069 into main May 7, 2025
1 check passed
@gina-yamada gina-yamada deleted the yamada/LG-16179-SetDocTypeOnInPersonEnrollmentForPassport branch May 7, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants