LG-16179 Set Document Type on InPersonEnrollment for Passports#12135
Merged
gina-yamada merged 7 commits intomainfrom May 7, 2025
Merged
Conversation
…n InPersonEnrollment for Passports
21 tasks
gina-yamada
commented
May 7, 2025
| put '/in_person' => 'in_person#update' | ||
| get '/in_person/choose_id_type' => 'in_person/choose_id_type#show' | ||
| put '/in_person/choose_id_type' => 'in_person/choose_id_type#update' | ||
| get '/in_person/passport' => 'in_person/passport#show' |
Contributor
Author
There was a problem hiding this comment.
This is a duplicate from https://github.com/18F/identity-idp/pull/12134/files
You can see get route exists below on line 452/451
shanechesnutt-ft
approved these changes
May 7, 2025
Contributor
shanechesnutt-ft
left a comment
There was a problem hiding this comment.
Ran through the tests and things look good. Nice job! 👍🏻
…79-SetDocTypeOnInPersonEnrollmentForPassport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-16179 Set Document Type on InPersonEnrollment for Passports
🛠 Summary of changes
📜 Testing Plan
Scenario: Global passports and In-Person Passports is enabled
You should not move on to the next step.(Code was merged in on 05/07 from another PR so you will move to the next page.) You should not see an AWS event log for Passport Submit. All are out of scope and being handled in another ticket.Other Scenarios: