Conversation
changelog: Bug Fixes, Authentication, Ensure new device is evaluated consistently in sign-in reCAPTCHA Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov>
Contributor
|
Changes look good to me. I'm wondering if there are any local watch_events that can show the effect? Or does it depend on having an API key to work? |
mdiarra3
approved these changes
May 6, 2025
Contributor
Author
The event is on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-15936: Bug: captcha_validation_performed is false even though reCAPTCHA was performed
🛠 Summary of changes
This PR adds logic to check for an existing device at the point of reCAPTCHA verification
📜 Testing Plan
Testing is unavailable on local machines. To verify, watch the data over time in CloudWatch to see if bug has been addressed.