LG-15988: Integrate second Department of State Health Check into IPP#12133
LG-15988: Integrate second Department of State Health Check into IPP#12133eileen-nava merged 6 commits intomainfrom
Conversation
…th check after post office selection
| @@ -0,0 +1,23 @@ | |||
| { | |||
| "name": "Passport Match Process API", | |||
| "status": "DOWN", | |||
There was a problem hiding this comment.
nit: The casing inside spec/fixtures/dos/healthcheck/composite_health_success.json is a little different in a few spots. ie: status is "Up", you have status as "DOWN". I am not sure what is expected from API but flagging it.
There was a problem hiding this comment.
The variation in status casing is intentional. It was in response to this feedback.
There was a problem hiding this comment.
It looks like Amir said okay for comments to be different casing. I am not seeing the green light for status. Sorry if I missed that.
| stub_health_check_endpoints_success | ||
| end | ||
|
|
||
| it 'directs the user to the choose id page with a deactivated passport option' do |
There was a problem hiding this comment.
Can we add something about the warning banner to this it statement? You did check for the warning message below
| attach_file t('doc_auth.headings.document_capture_back'), file, make_visible: true | ||
| end | ||
|
|
||
| def attach_and_submit_passport_image |
There was a problem hiding this comment.
Is this being used? I wondered why it was added.
There was a problem hiding this comment.
It's not needed. I removed it in f130c5a. (Additional context: I was previously using it in the feature specs for the hybrid flow. Since hybrid flow is now out of scope for this ticket, I deleted the associated specs, but missed deleting this method. Thanks for catching that!)
🎫 Ticket
LG-15988: Integrate second Department of State Health Check into IPP
🛠 Summary of changes
📜 Testing Plan
Scenario: Global passports and In-Person Passports are enabled.
application.ymlset-up below:Scenario: Global passports and In-Person Passports are enabled. The health check fails. The user gets navigated to the choose id page and the passport option is deselected.
This manual test requires a change to
application.ymlmidway through testing.Initial
application.ymlset-up below:Scenario: Global passports are enabled and in-person passports is disabled
Setup below:
👀 Screenshots that show alert text for Scenario 2
If relevant, include a screenshot or screen capture of the changes.
English:
Spanish:
French:
Chinese: