Skip to content

LG-15988: Integrate second Department of State Health Check into IPP#12133

Merged
eileen-nava merged 6 commits intomainfrom
em/15988-dos-second-health-check
May 6, 2025
Merged

LG-15988: Integrate second Department of State Health Check into IPP#12133
eileen-nava merged 6 commits intomainfrom
em/15988-dos-second-health-check

Conversation

@eileen-nava
Copy link
Copy Markdown
Contributor

@eileen-nava eileen-nava commented May 2, 2025

🎫 Ticket

LG-15988: Integrate second Department of State Health Check into IPP

🛠 Summary of changes

  • When passports are globally enabled and enabled for IPP, and the first health check passes, and the user opts into IPP, and the user selects their post office, then the second health check fails.......
  • user is navigated to the choose id page
  • the passport option is deactivated (user should not be able to select it)
  • alert text appears at the top of the page
  • the driver's license option is automatically selected

📜 Testing Plan

  • Only test the standard flow for opt-in IPP. Other flows are out of scope

Scenario: Global passports and In-Person Passports are enabled.
application.yml set-up below:

in_person_proofing_enabled: true
in_person_proofing_opt_in_enabled: true
in_person_passports_enabled: true
doc_auth_passports_enabled: true
doc_auth_passports_percent: 100
  • Login through the oidc sinatra application and select the Identity Verified level of service.
  • Create a new account
  • Begin the ID-IPP flow and navigate to the post office selection page
  • Select a post office
  • Ensure user is navigated to the choose ID type page.

Scenario: Global passports and In-Person Passports are enabled. The health check fails. The user gets navigated to the choose id page and the passport option is deselected.
This manual test requires a change to application.yml midway through testing.
Initial application.yml set-up below:

in_person_proofing_enabled: true
in_person_proofing_opt_in_enabled: true
in_person_passports_enabled: true
doc_auth_passports_enabled: true
doc_auth_passports_percent: 100
  • Login through the oidc sinatra application and select the Identity Verified level of service.
  • Create a new account
  • Begin the ID-IPP flow and navigate to the post office selection page
  • Stop the rails server and add the below to application.yml
dos_passport_composite_healthcheck_endpoint: "http://localhost:3000/healthcheck"
  • Start the rails server again
  • Select a post office
  • Ensure user is navigated to the choose ID type page
  • Ensure that the passport option is deselected.
  • Ensure you see the alert text (I included screenshots to demonstrate the alert text.)

Scenario: Global passports are enabled and in-person passports is disabled
Setup below:

in_person_proofing_enabled: true
in_person_proofing_opt_in_enabled: true
in_person_passports_enabled: false
doc_auth_passports_enabled: true
doc_auth_passports_percent: 100
  • Login through the oidc sinatra application and select the Identity Verified level of service.
  • Create a new account
  • Begin the ID-IPP flow and navigate to the post office selection page
  • Select a post office
  • Ensure user is navigated to the state ID page

👀 Screenshots that show alert text for Scenario 2

If relevant, include a screenshot or screen capture of the changes.

English:

15988HealthCheckFailsEnglish

Spanish:

15988HealthChecksFailsSpanish

French:

15988HealthChecksFailsFrench

Chinese:

15988HealthCheckFailsChinese

@eileen-nava eileen-nava changed the title Em/15988 dos second health check LG-15988: Integrate second Department of State Health Check into IPP May 2, 2025
@eileen-nava eileen-nava requested review from a team, rutvigupta-design, shanechesnutt-ft and theabrad and removed request for a team May 2, 2025 19:47
Copy link
Copy Markdown

@rutvigupta-design rutvigupta-design left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, this LGTM! 🎉

@@ -0,0 +1,23 @@
{
"name": "Passport Match Process API",
"status": "DOWN",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: The casing inside spec/fixtures/dos/healthcheck/composite_health_success.json is a little different in a few spots. ie: status is "Up", you have status as "DOWN". I am not sure what is expected from API but flagging it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variation in status casing is intentional. It was in response to this feedback.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like Amir said okay for comments to be different casing. I am not seeing the green light for status. Sorry if I missed that.

stub_health_check_endpoints_success
end

it 'directs the user to the choose id page with a deactivated passport option' do
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add something about the warning banner to this it statement? You did check for the warning message below

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See f130c5a.

attach_file t('doc_auth.headings.document_capture_back'), file, make_visible: true
end

def attach_and_submit_passport_image
Copy link
Copy Markdown
Contributor

@gina-yamada gina-yamada May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this being used? I wondered why it was added.

Copy link
Copy Markdown
Contributor Author

@eileen-nava eileen-nava May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not needed. I removed it in f130c5a. (Additional context: I was previously using it in the feature specs for the hybrid flow. Since hybrid flow is now out of scope for this ticket, I deleted the associated specs, but missed deleting this method. Thanks for catching that!)

Copy link
Copy Markdown
Contributor

@gina-yamada gina-yamada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I walked through your testing plan. Everything checks out. I added a few comments but nothing blocking.

I'd say nice to have one more approver before merging if you can get it.

Copy link
Copy Markdown
Contributor

@lmgeorge lmgeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good work 🚀 and nice updates to the testing plan.

@eileen-nava eileen-nava merged commit 49fe563 into main May 6, 2025
1 check passed
@eileen-nava eileen-nava deleted the em/15988-dos-second-health-check branch May 6, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants