LG-16117 Create A/B test toggle to support manual upload removal#12139
Merged
LG-16117 Create A/B test toggle to support manual upload removal#12139
Conversation
Co-authored-by: Malik Warren <malik.warren@gsa.gov>
changelog: Upcoming Features, Doc Auth, add a/b test for disabling manual document upload
amirbey
reviewed
May 6, 2025
config/application.yml.default
Outdated
| doc_auth_error_glare_threshold: 40 | ||
| doc_auth_error_sharpness_threshold: 40 | ||
| doc_auth_manual_upload_disabled_a_b_testing_enabled: false | ||
| doc_auth_manual_upload_disabled_a_b_testing_percent: 50 |
Contributor
There was a problem hiding this comment.
Suggested change
| doc_auth_manual_upload_disabled_a_b_testing_percent: 50 | |
| doc_auth_manual_upload_disabled_a_b_testing_percent: 0 |
amirbey
reviewed
May 6, 2025
| user&.uuid | ||
| end.freeze | ||
|
|
||
| DOC_AUTH_MANUAL_UPLOAD_DISABLED = AbTest.new( |
Contributor
There was a problem hiding this comment.
Suggested change
| DOC_AUTH_MANUAL_UPLOAD_DISABLED = AbTest.new( | |
| DOC_AUTH_MANUAL_UPLOAD_ENABLED = AbTest.new( |
for readability, i prefer affirmative as opposed to having to later use/read double negatives( ie: !disabled)... could choose to rename throughout PR, but your call
Contributor
Author
There was a problem hiding this comment.
True. Would we have to change the percentage around for the affirmative if we change to enabled? For example with the disabled name it would be doc_auth_manual_upload_disabled_percent: 15. Would we use doc_auth_manual_upload_enabled_percent: 85 instead?
Contributor
There was a problem hiding this comment.
i tend to default percentages to 0 .... and i see your point
ultimately... this is temporary ... i think it's fine to leave as is 👍🏿
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-16117
🛠 Summary of changes
Set up the initial A/B testing for disabling manual document upload.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.