LG-16086 Add address, ssn, and verify info to IPP passport flow#12134
Merged
shanechesnutt-ft merged 1 commit intomainfrom May 7, 2025
Merged
LG-16086 Add address, ssn, and verify info to IPP passport flow#12134shanechesnutt-ft merged 1 commit intomainfrom
shanechesnutt-ft merged 1 commit intomainfrom
Conversation
d965e40 to
bb8da98
Compare
bb8da98 to
3b7863c
Compare
eileen-nava
approved these changes
May 6, 2025
Contributor
eileen-nava
left a comment
There was a problem hiding this comment.
Good work. Approved.
3b7863c to
0a73c9f
Compare
lmgeorge
approved these changes
May 6, 2025
Contributor
lmgeorge
left a comment
There was a problem hiding this comment.
This looks good! I have a question that can be addressed/fixed in a separate story since we don't have all of the analytics events hammered out just yet.
Contributor
There was a problem hiding this comment.
Question: Are there PII-like keypaths that need to be redacted as part of event that gets logged on submission of address?
Contributor
Author
There was a problem hiding this comment.
It looks like the only thing we log in the address submitted event is the zipcode for the current address.
changelog: Upcoming Features, In-person proofing, Add address, ssn, and verify info to IPP passport flow
0a73c9f to
0192a4b
Compare
gina-yamada
reviewed
May 7, 2025
| as: :in_person_ready_to_verify | ||
| post '/in_person/usps_locations' => 'in_person/usps_locations#index' | ||
| put '/in_person/usps_locations' => 'in_person/usps_locations#update' | ||
| get '/in_person/passport' => 'in_person/passport#show' |
Contributor
There was a problem hiding this comment.
@shanechesnutt-ft Show is a dup. I will clean it up in my branch #12135
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-16086
🛠 Summary of changes
Add address, ssn, and verify info to IPP passport flow
📜 Testing Plan
Setup: Ensure the following environment variables are set for passport to work in IPP.
Scenario: User selects passport option and completes update verify info
Note: Verify info was out of scope for this story so no content needs to be verified on that page
Scenario: User selects
passport optiondriver's license or state ID and completes update verify infoNote: Verify info was out of scope for this story so no content needs to be verified on that page