Closed
Conversation
**Why**: RISC notifications are delivered through an ActiveJob; inline invocation is no longer used. **How**: 1. Remove references to risc_notifications_active_job_enabled in code and assume it to be true 2. Refactor tests to assert that RiscDeliveryJob is scheduled with the correct arguments changelog: Internal, RISC, Remove obsolete code
changelog: Bug Fixes, Accessibility, Render email language preference as language of parts
* Replace Alert component "other" as default style changelog: Internal, UI Components, Replace Alert component "other" as default style * Shift nil validation to VALID_TYPES See: https://github.com/18F/identity-idp/pull/10779/files#r1631544531
* Standardize form validation for WebauthnSetupForm changelog: Internal, WebAuthn, Standardize form validation for WebauthnSetupForm * Add attestation validation error to attestation_object More appropriate than `name`
* LG-13570 we were parsing JSON as JSON and that was bad * LG-13570 lint corrections changelog: Bug Fixes, Reports, Resolve double-parsing JSON in Dropoff report (LG-13570)
Contributor
|
this is not a patch deploy? I would expect us to just be deploying one commit so to make the branch it would look like and make a PR out of that |
Contributor
Author
|
This is incorrect, it contains work I don't want in the patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fixes
Internal