Merged
Conversation
* Remove unused stored_location analytics parameter changelog: Internal, Analytics, Reduce payload size of common analytics events * Remove lingering references to stored_location
* LG-12296: WIP * LG-12296: log workflow for doc auth image upload vendor submitted. changelog: Internal, Analytics, Log workflow for doc image upload vendor submitted event. * LG-12296: cleanup. * LG-12296: use reference from request other than response where it can be missing. * LG-12296: do less.
* changelog: Bug Fixes, Remove Unused Providers, fix error encountered when removing providers without integrations * add additional test for integration with no usages * Update lib/cleanup/destroyable_records.rb Co-authored-by: Davida (she/they) <davida.marion@gsa.gov> --------- Co-authored-by: Davida (she/they) <davida.marion@gsa.gov>
* Add server-side validation for frontend errors filtering changelog: Internal, Error Logging, Ignore frontend errors not originating from application script * Fix / generalize FrontendErrorLogger spec * Stub validation for expected error logging * Fix nil filename handling
Redirect user to re-enter their password if PII is missing from their session. This re-uses the "invalid personal key" path. changelog: Bug Fixes,Personal Key Creation,Handle a rare error gracefully
…#10095) SAML SPs can request IALMax by using an IAL authn context that does not require proofing and including a Authn Context Comparison value of "minimum". This essentially says that the "IAL1" Authn context is the minimum acceptable context so "IAL2" is also acceptable. This is problematic for the new `AuthnContextResolver` since it does not have visibility into these attributes on the SAML request when resolving the authn context. This commit addresses the issue by returning the IALMax Authentication Context Reference from `Saml#ial` in this case. This way the IALMax value is picked up downstream by the `AuthnContextResolver`. This type of request has a few differences from an IALMax request with the IALMax authn context reference: - If a service provider that cannot make IAL2 requests makes an IAL1 request in this way it will always be serviced without proofed attributes. An IALMax request with the IALMax authn context reference for a service provider that cannot make IAL2 requests results in an error. - If a service provider is not on the list of SPs that can make an IALMax request but requests IALMax in this way it will be allowed. I am not sure if this is intended but it is the behavior prior to this commit so it is not a regression. [skip changelog]
* Add email_address_id field to oncall/email-deliveries script changelog: Internal, Scripts, Add email_address_id field to oncall/email-deliveries script * truncate message_id
* Bump Stylelint dependency to support v16 changelog: Internal, Dependencies, Update dependencies to latest versions Closes #10124 * stylelint-config: Prepare 4.0.0 release * Remove stray colon
* Upgrade msw to 2.x changelog: Internal, Dependencies, Update dependencies to latest versions * Yarn deduplicate * build-sass: Update Chokidar to resolve typings conflict * Sync yarn.lock
…inker (#10107) * add acr_values and vtr to IdentityLinker * OpenidConnectAuthorizeForm#link_identity_to_service_provider now links acr_values and vtr * add changelog changelog: Internal, IdV, write acr_values and vtr to identites table * change vtr in spec to JSON array * make sure to join acr_values to properly parse * fix specs for oidc authorize form
In a previous commit the `resolved_authn_context_result` was introduced to return a `Vot::Parser::Result` object that described the requirements for the current SP request considering SP default options. This is intended to be used to replace the keys in the `sp_session` that serve this purpose including the `ial` key. This commit replaces places where the `sp_session[:ial]` value is read with new reads to the `resolved_authn_context_result`. [skip changelog]
changelog: Internal, Dependencies, Update Rails
…10127) The `sp_session[:ial2]` and `sp_session[:ialmax]` values are being retired in favor of `resolved_authn_context_result.identity_proofing?` and `resolved_authn_context_result.ialmax?`. This commit does the work of removing these 2 values from `SignUp::CompletionsController`. This removes the last of the references for `sp_session[:ialmax]` so once this is merged and deployed we can stop writing that value. [skip changelog]
We are replacing the `sp_sesison[:ial2]` value with checks against `resolved_authn_context_result.identity_proofing?`. This commit removes the places where we are reading `sp_sesison[:ial2]`. Once this is merged and fully deployed we can stop writing `sp_session[:ial2]`. [skip changelog]
* Adapt skipped strong password test for partial match behavior changelog: Internal, Automated Testing, Add test coverage for strong password testing of email component * Revise test description for accuracy
zachmargolis
approved these changes
Feb 22, 2024
jmhooper
added a commit
that referenced
this pull request
Feb 22, 2024
Revert "Merge pull request #10136 from 18F/stages/rc-2024-02-22"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fixes
Internal