LG-12283 handle missing PII in session#10103
Merged
Conversation
Extracted `redirect_to_retrieve_pii` changelog: Bug Fixes,Personal Key Creation,Handle a rare error gracefully
a5af0ff to
e234426
Compare
matthinz
reviewed
Feb 16, 2024
Contributor
matthinz
left a comment
There was a problem hiding this comment.
I've tested this and it works as described! Nice! Just the one comment about analytics.
matthinz
approved these changes
Feb 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-12283
🛠 Summary of changes
Added code to
PersonalKeyController#showto catch a situation where we very occasionally have no PII available in the session when we are about to try to encrypt PII from the session.In this case, we redirect to the code for a missing or bad personal key, which prompts the user for their password and retrieves the PII. We also arrange to return here afterward.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
binding.pryat the top ofPersonalKeyController#show👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
Re-entering your password:
Personal key page: