Skip to content

Remove unused stored_location analytics parameter#10105

Merged
aduth merged 2 commits intomainfrom
aduth-rm-unused-stored-location
Feb 20, 2024
Merged

Remove unused stored_location analytics parameter#10105
aduth merged 2 commits intomainfrom
aduth-rm-unused-stored-location

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Feb 16, 2024

🛠 Summary of changes

Removes the stored_location analytics property from the 'Sign in page visited' and 'Email and Password Authentication' analytics events.

This references a session value user_return_to that is not assigned, last referenced removed in #5413.

Tangentially-related Slack discussion: https://gsa-tts.slack.com/archives/C0NGESUN5/p1706906370684589

Why?

  • Reduce logging payload size for frequent analytics events
  • Avoid misleading developers to imply we track return location for sign-in, since we don't (LG-3737)

📜 Testing Plan

  1. In a separate terminal process, run make watch_events
  2. Go to http://localhost:3000
  3. Observe logged event for "Sign in page visited" does not include stored_location
  4. Sign in
  5. Observe logged event for "Email and password authentication" does not include stored_location

changelog: Internal, Analytics, Reduce payload size of common analytics events
@aduth aduth merged commit c099dc7 into main Feb 20, 2024
@aduth aduth deleted the aduth-rm-unused-stored-location branch February 20, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants