LG-12150 Write acr_values and vtr to identites table using identity linker#10107
Merged
LG-12150 Write acr_values and vtr to identites table using identity linker#10107
Conversation
acr_values and vtr
changelog: Internal, IdV, write acr_values and vtr to identites table
Comment on lines
+33
to
+34
| acr_values = 'http://idmanagement.gov/ns/assurance/aal/1' | ||
| vtr = 'C2.Pb' |
Contributor
There was a problem hiding this comment.
my expectation is that we allow arrays here? are these array columns or single columns
Contributor
There was a problem hiding this comment.
These are string columns. The acr_values param that gets passed into the VoT Parser is a string so the VoT Parser can parse it.
We probably want vtr to be a JSON array here though.
jmhooper
reviewed
Feb 21, 2024
| rails_session_id: rails_session_id, | ||
| ial: ial_context.ial, | ||
| aal: aal, | ||
| acr_values: acr_values, |
Contributor
There was a problem hiding this comment.
I think that here we want to acr_values.join(' ') to ensure they are able to be properly parsed by the Vot::Parser. It expects these to be separated by spaces.
jmhooper
approved these changes
Feb 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-12150
🛠 Summary of changes
This is part two of being able to create an identity token with acr and vectors of trust values. This writes acr_values and vtr params into the identities table so we will be able to read from them later when creating the id token.