Feature implementation from commits 6510d81..a218dfa #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lokesh Mandvekar <[email protected]>
If we're not planning to automatically push every new release to centos stream, then this job only ends up causing noise. Signed-off-by: Lokesh Mandvekar <[email protected]>
Added support for "podman buildx inspect". The goal was to replicate the default output from "docker buildx inspect" as much as possible but a problem encountered was podman not supporting BuildKit. To replicate the output I resorted to printing the statements with default values but only changed the driver name to use podman instead of docker. Since there was no buildkit, gave it the value of "N/A" to depict it's not supported. For Platforms, I resorted to using the emulated architectures found on your linux system + the host architecture of your local machine or podman server. The bootstrap flag was also added but is considered a NOP since there is no buildkit container to run before running inspect. An extra field was added to the HostInfo struct so when you run "podman info" the emulated architectures will show, this was used so you can grab the information from the podman engine. Fixes containers#13014 Signed-off-by: Joshua Arrevillaga <[email protected]>
this patch changes how the detection of wsl works. The old way of using wsl --status command output to detect some missing features required by WSL is not fully reliable. WSL checks if the wsl feature is enabled and if the vmcompute service do exist. However, this is not enough to identify if the virtual machine platform feature is enabled. The vmcompute service could exist because it has been installed by other tools or it could exist but being stopped. The way proposed by this patch is to try execute the import command and, if it fails, check the error and if it is related to the Host Compute Service try to install all features required by WSL. The flow is the same as before, the user is asked to execute the podman machine init command with elevated privileges. Eventually, after enabling WSL and VMP features, the user is asked to reboot the machine. When the machine restarts, the powershell gets invoked again and execute the command init. The code also fixes some issues that could cause misbehaviors when invoking recursively the elevated shell, like an unreleased lock, or a missing file. Signed-off-by: lstocchi <[email protected]>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Two incomptable changes, they removed the BridgeNfIP6tables and BridgeNfIptables fields so we must drop them. As they are not important ones that should not cause problems. Second, they moved to using DockerOCIImageConfig from another new module. The json format did not chnage so this is not an external API break. Signed-off-by: Paul Holzinger <[email protected]>
Signed-off-by: Paul Holzinger <[email protected]>
Includes one breaking change for the flag as BuildOutputs now accept a slice. Signed-off-by: Paul Holzinger <[email protected]>
Newer versions expect to use a new test helper. Signed-off-by: Nalin Dahyabhai <[email protected]> Signed-off-by: Paul Holzinger <[email protected]>
The buildah test code chnages so I had to manually resolve the conflict. Signed-off-by: Paul Holzinger <[email protected]>
The --output option is not supported with remote. Signed-off-by: Paul Holzinger <[email protected]>
This makes sure that the volume source is available before the volume is created. Fixes: containers#26125 Signed-off-by: Hiếu Lê <[email protected]>
We disabled it in the machine os image so it can no longer be used currently. Signed-off-by: Paul Holzinger <[email protected]>
Do not write /etc/environment.d files, something is broken in the new image that causes the boot to fail when any basic var is set there. Signed-off-by: Paul Holzinger <[email protected]>
pkg/machine/e2e: skip rosetta test
It has not been in use since commit f218f84 and should have been removed there. It seems somehow it is causing a bug since our env file is empty. In that case it triggers a segfault and since that happens from within pam we are unable to login in any way. I reported the issue[1] but because we don't need this just remove it so we don't have to wait for a fix. [1] https://bugzilla.redhat.com/show_bug.cgi?id=2370858 Signed-off-by: Paul Holzinger <[email protected]>
This reverts commit 0b8dd90. Signed-off-by: Paul Holzinger <[email protected]>
This is not used in the code so it can be deleted. Signed-off-by: Paul Holzinger <[email protected]>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…rg-x-net-0.x fix(deps): update module golang.org/x/net to v0.41.0
pkg/machine: remove some unsused services and add the /etc/environment.d SSL vars back
…om-vbauerster-mpb-v8-8.x fix(deps): update module github.com/vbauerster/mpb/v8 to v8.10.2
vendor: update docker, common, image, storage and buildah
Git commit 0c3b5e4 added a comment that RemapUsers is deprecated. Use UserNS=keep-id instead. Signed-off-by: Erik Sjölund <[email protected]>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This exclusion has been there since the make target was added[1]. I wasn't able to find the reason but this runs on Darwin today and is useful to be able to run when you are developing bindings on a Mac. [1] containers#8956 Signed-off-by: Lewis Roy <[email protected]>
The local-cross Make target has superceeded this old Make target and the warning to not use it has been in place now for 4+ years. Removing it to clean up the Makefile slightly. Signed-off-by: Lewis Roy <[email protected]>
…om-go-swagger-go-swagger-0.x Update module github.com/go-swagger/go-swagger to v0.32.3
Remove bin/podman.cross Make target
Packit cleanups
The following manpages were missing examples of the `--all` flag: * podman init * podman pod pause * podman secret rm * podman system connection remove * podman system prune Added examples of all. Fixes containers#26354 Signed-off-by: Matt Heon <[email protected]>
Enable linter rule ST1005 - Incorrectly formatted error string Signed-off-by: Marek Libra <[email protected]>
Fix containers#26355 Signed-off-by: Jarek Górny <[email protected]>
The --pod flag is important for users working with pods but lacked documentation examples. Added examples showing: - Basic --pod usage to display pod information - Using --pod with -a to show all containers and their pods - Filtering containers by pod name - Custom formatting with pod-related placeholders Also: removed trailing whitespace on a few lines Fixes containers#26367 Assisted-by: Claude Sonnet 4 Removed trailing whitespace on a few lines Signed-off-by: Mike McGrath <[email protected]> MH: Squashed, force-pushed to reset CI Signed-off-by: Matt Heon <[email protected]>
Add examples of `--all` flag
fix(ci): add ST1005 linter rule
Fix 26355: move 'Examples' section down in the podman-volume-create
Signed-off-by: Marek Libra <[email protected]>
…page-format Fix stats manpage format - fix for containers#26367
Fixes containers#26358 Signed-off-by: Jitka Obselkova <[email protected]>
fix wsl install workflow on machine init command
fix 26348: add container diff --latest doc
Update podman system prune doc
The prior commit that expanded the examples added an out of place heading to the manpage for podman-ps, which looks like a probable AI tool hallucination. Signed-off-by: Daniel P. Berrangé <[email protected]>
docs: remove bogus markdown heading in podman-ps
If the artifact has a single blob then use the dst path directly as mount in case it does not exist. Signed-off-by: Paul Holzinger <[email protected]>
Signed-off-by: shu-kitamura <[email protected]>
An artifact without the title annoation just gets the digest as name which is less than ideal. While it is a decent default to avoid conflicts users would like to configure the name. With the name=abc option we will call the file abc in case of a signle artifact and otherwise we use abc-x where x is the layer index starting at 0 to avoid conflicts. Signed-off-by: Paul Holzinger <[email protected]>
This rule was incorrectly disabled in containers#26400 You can see here [1] adding "-" disables a rule and ST1005 is enabled by default. [1] https://golangci-lint.run/usage/linters/#staticcheck Signed-off-by: Lewis Roy <[email protected]>
[CI] Correct ST1005 staticcheck lint rule
docs: add examples to podman-system-migrate man page
artifact mount: improve single file behavior and add name option to specify a custom container name
…ress Manpages: podman network connect missing example with --mac-address option
This patch adds an example of using the --time option to the podman-network-rm.1 man page. Fixes: containers#26373 Signed-off-by: shu-kitamura <[email protected]>
podman-update: fix block device handling
Signed-off-by: Benjamin Akhras <[email protected]>
Signed-off-by: shu-kitamura <[email protected]>
…g-docs Issue 26349 force flag docs
…-rm-time docs: add an example to podman-network-rm man page
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes from a range of commits from the original repository.
Commit Range:
6510d81..a218dfaFiles Changed: 798 (557 programming files)
Programming Ratio: 69.8%
Commits included:
... and 89 more commits