Skip to content

Conversation

@shu-kitamura
Copy link
Contributor

This patch adds an example of using the --time option to the podman-network-rm.1 man page.

Fixes: #26373

Does this PR introduce a user-facing change?

None

This patch adds an example of using the --time option to the podman-network-rm.1 man page.

Fixes: #26373
Signed-off-by: shu-kitamura <[email protected]>
@packit-as-a-service
Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

Delete specified network and all containers associated with the network after waiting up to 15 seconds:
```
# podman network rm --force --time 15 fred
Deleted: fred
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it is wrong in the examples above as well but the command output is incorrect. It just prints the name, i.e. fred without the Deleted: prefix

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you know, the Deleted: prefix is ​​not included in the command output. Only fred is included.

I am thinking of removing the Deleted: prefix.

The existing examples also contain the Deleted: prefix, but they also only output fred.

So I think it would be better to remove the Deleted: prefix from the existing examples as well.

Are you on the same page?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we should remove it from all examples

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the Deleted: prefix in commit 4ec7d35.

@baude
Copy link
Member

baude commented Jun 17, 2025

LGTM

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, shu-kitamura

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 20d5b78 into containers:main Jun 17, 2025
35 of 36 checks passed
@shu-kitamura shu-kitamura deleted the example_network-rm-time branch June 17, 2025 13:54
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 16, 2025
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Sep 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Manpages: podman network rm missing example with --time option

3 participants