-
Notifications
You must be signed in to change notification settings - Fork 2.9k
docs: add an example to podman-network-rm man page #26442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add an example to podman-network-rm man page #26442
Conversation
This patch adds an example of using the --time option to the podman-network-rm.1 man page. Fixes: #26373 Signed-off-by: shu-kitamura <[email protected]>
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
| Delete specified network and all containers associated with the network after waiting up to 15 seconds: | ||
| ``` | ||
| # podman network rm --force --time 15 fred | ||
| Deleted: fred |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it is wrong in the examples above as well but the command output is incorrect. It just prints the name, i.e. fred without the Deleted: prefix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you know, the Deleted: prefix is not included in the command output. Only fred is included.
I am thinking of removing the Deleted: prefix.
The existing examples also contain the Deleted: prefix, but they also only output fred.
So I think it would be better to remove the Deleted: prefix from the existing examples as well.
Are you on the same page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes we should remove it from all examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the Deleted: prefix in commit 4ec7d35.
Signed-off-by: shu-kitamura <[email protected]>
|
LGTM |
Luap99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, shu-kitamura The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
20d5b78
into
containers:main
This patch adds an example of using the
--timeoption to the podman-network-rm.1 man page.Fixes: #26373
Does this PR introduce a user-facing change?