Manpages: podman network connect missing example with --mac-address option

[shu-kitamura]

Hello!

I added example with --mac-address option for podman network connect

Fixes: #26374

Does this PR introduce a user-facing change?

None

None

[Luap99]

Thanks, you will have to add a DCO signoff to the commit message see https://github.com/containers/podman/blob/main/CONTRIBUTING.md#sign-your-prs

Also if you are going to repush it would be nice to add the Fixes: #26374 also as part of the commit message.

[shu-kitamura]

Thanks for your check.
I added the DCO signoff and Fixes: #26374 to the commit message and repush it.

[Luap99]

LGTM

FYI the Fixes: #xxx should generally go on a separate line at the end of the commit and not as part of the title but that is not a blocker.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, shu-kitamura

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [Luap99]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[shu-kitamura]

@Luap99 May I ask a question?

I have read the code review process. I understand that PRs are merged in the following way:

• In phase 1, the lgtm label is added based on the reviewer's comments
• In phase 2, the approved label is added based on the approver's comments
• In phase 3, it is automatically merged (if the conditions are met)

Currently, the approved label has been added, but the lgtm label has not yet been added.
Do I need to get another reviewer to review this PR?

[baude]

• In phase 1, the lgtm label is added based on the reviewer's comments
• In phase 2, the approved label is added based on the approver's comments

@Luap99 May I ask a question?

I have read the code review process. I understand that PRs are merged in the following way:

• In phase 1, the lgtm label is added based on the reviewer's comments
• In phase 2, the approved label is added based on the approver's comments
• In phase 3, it is automatically merged (if the conditions are met)

Currently, the approved label has been added, but the lgtm label has not yet been added. Do I need to get another reviewer to review this PR?

Yes, the process requires a second lgtm where the lgtm is preceeded by a /. Also, imho, phase 2 can occur before phase 1 because we don't really take advantage of the approved label. I will review and merge your PR now if it is up to snuff.

[baude]

/lgtm