Makefile: add target to generate bindings #8956
Conversation
openshift-ci-robot
added
the
approved
|
@baude @vrothberg @nalind PTAL |
There was a problem hiding this comment.
Looks like the build tests are failing because generate now has a dependency on goimports being in $PATH now? If a user doesn't have goimports in their path, the imports will not be correctly done.
I also would prefer it if we kept the generated time in the generated files.
Also, generating the bindings touches go.mod and go.sum and throws a bunch of inconsistent vendoring errors at me. Not entirely sure what's going on, but that might be my fault.
The files are correctly generated though, so that's good
rhatdan
force-pushed
the
Makefile
branch
15 times, most recently
from
2ab2fcb to
c1e1faa
Compare
rhatdan
force-pushed
the
Makefile
branch
2 times, most recently
from
886cfb1 to
925b0ac
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rhatdan
force-pushed
the
Makefile
branch
2 times, most recently
from
5e9827b to
0277ddb
Compare
pkg/bindings/generator/generator.go
Outdated
There was a problem hiding this comment.
gofmt is not available in path on a lot of ci/cd images, go fmt seems to work, so I switched to it.
go fmt [-n] [-x] [packages]
Fmt runs the command 'gofmt -l -w' on the packages named
by the import paths. It prints the names of the files that are modified.
For more about gofmt, see 'go doc cmd/gofmt'.
For more about specifying packages, see 'go help packages'.
The -n flag prints commands that would be executed.
The -x flag prints commands as they are executed.
The -mod flag's value sets which module download mode
to use: readonly or vendor. See 'go help modules' for more.
To run gofmt with specific options, run gofmt itself.
See also: go fix, go vet.
There was a problem hiding this comment.
Because this will cause us to have to update the bindings every time you run create bindings even if the bindings did not change.
There was a problem hiding this comment.
go generate does this not, me.
There was a problem hiding this comment.
this is likely your problem. looking into why.
There was a problem hiding this comment.
Yup, this gets removed when you go generate, I tried to hard code this back in, but it caused other tools to break.
Strange that I can not get this same error to happen with podman-remote ps --last 1.
Add a `.generate-bindings` make target that only runs in the absence of the `.generate-bindings` file or when a `types.go` file below `pkg/bindings` has changed. This will regenerate the go bindings and make sure the code is up2date. Signed-off-by: Valentin Rothberg <[email protected]> Signed-off-by: Daniel J Walsh <[email protected]>
|
/lgtm hold |
|
LGTM |
github-actions
bot
added
the
locked - please file new issue/PR
8 participants
Add a
.generate-bindingsmake target that only runs in the absence ofthe
.generate-bindingsfile or when atypes.gofile belowpkg/bindingshas changed.It does not execute anything yet is just a template to wire in the
generation in a future change.
Signed-off-by: Valentin Rothberg [email protected]
Signed-off-by: Daniel J Walsh [email protected]