artifact mount: improve single file behavior and add name option to specify a custom container name #26430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the artifact has a single blob then use the dst path directly as mount in case it does not exist. Signed-off-by: Paul Holzinger <[email protected]>
An artifact without the title annoation just gets the digest as name which is less than ideal. While it is a decent default to avoid conflicts users would like to configure the name. With the name=abc option we will call the file abc in case of a signle artifact and otherwise we use abc-x where x is the layer index starting at 0 to avoid conflicts. Signed-off-by: Paul Holzinger <[email protected]>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Member
Author
|
cc @baude |
Member
|
LGTM |
Member
|
/lgtm |
openshift-merge-bot
bot
merged commit 233cae8
into
containers:main
76 of 77 checks passed
stale-locking-app
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the artifact has a single blob then use the dst path directly as
mount in case it does not exist.
An artifact without the title annoation just gets the digest as name
which is less than ideal. While it is a decent default to avoid
conflicts users would like to configure the name.
With the name=abc option we will call the file abc in case of a signle
artifact and otherwise we use abc-x where x is the layer index starting
at 0 to avoid conflicts.
Does this PR introduce a user-facing change?