Skip to content

Conversation

@kidunot89
Copy link
Contributor

@kidunot89 kidunot89 commented Jan 12, 2021

Fixes #000.

Describe your approach and how it fixes the issue.

Checklist

  • Project documentation has been updated to reflect the changes in this pull request, if applicable.
  • I have tested the changes in the local development environment (see contributing.md).
  • I have added phpunit tests.

Release Changelog

  • New: Action added for when a blog is deleted #1177, props @kidunot89
  • Fix: Refactored Stream's Records table custom column functionality to output the correct column values #1185, props @Nikschavan, @kidunot89, and @derekherman
  • Fix: Refactored deprecated SQL statement for retrieving the result count #1203, props @kidunot89
  • Fix: Fixed a namespace of a call to the Closure class #1215, props @szepeviktor
  • Fix: The default options are made available during the "wp_stream_auto_purge" callback #1159, props @kidunot89
  • Fix: Expensive functions removed #1201, props @kidunot89
  • Tweak: Remove redundant textdomain initialization #1213, props @szepeviktor
  • Tweak: Cleaned up PHP version check #1212, props @szepeviktor
  • Development: Unit test added for Menu connector class #1164, props @kidunot89
  • Development: Unit test added for Blog connector class #1177, props @kidunot89
  • Development Fix: Micro patch provided for Mercator actions register to deprecated hooks #1217, props @kidunot89
  • Development: Unit test added for Mercator connector class #1180, props @kidunot89
  • Development: Unit test added for Settings connector class #1165, props @kidunot89
  • Development: Unit test added for Installer connector class #1155, props @kidunot89
  • Development: Unit test added for User connector class #1151, props @kidunot89
  • Development: Unit test added for Editor connector class #1138, props @kidunot89
  • Development: Unit test added for Comments connector class #1134, props @kidunot89

Release Checklist

  • This pull request is to the master branch.
  • Release version follows semantic versioning. Does it include breaking changes?
  • Update changelog in readme.txt.
  • Bump version in stream.php.
  • Bump Stable tag in readme.txt.
  • Bump version in classes/class-plugin.php.
  • Draft a release on GitHub.

kasparsd and others added 30 commits August 14, 2020 15:21
…/release-tagging

# Conflicts:
#	local/scripts/dist.sh
Automatically tag releases in the distribution repository
CI locked to composer version 1 until support for composer 2 added.
`wp_stream_fail_php_version` does it itself.
Improve PHP version checking
Update dependency grunt-contrib-compress to v2
Settings connector test implemented.
@kidunot89 kidunot89 force-pushed the release/3.6.1 branch 3 times, most recently from 09a4400 to 0106e74 Compare January 22, 2021 23:57
Copy link
Contributor

@kasparsd kasparsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kidunot89 I just noticed that one unit test is failing at PHP 5.6 https://travis-ci.com/github/xwp/stream/jobs/474533888#L534-L542

1) WP_Stream\Test_WP_Stream_Connector_Posts::test_callback_transition_post_status
Expectation failed for method name is equal to <string:log> when invoked 12 time(s)
Parameter 0 for invocation #5 WP_Stream\Connector::log('"%1$s" %2$s published', Array (...), 327, 'post', 'updated', null) does not match expected value.
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'"%1$s" %2$s scheduled for %3$s'
+'"%1$s" %2$s published'
/var/www/html/wp-content/plugins/stream-src/connectors/class-connector-posts.php:303
/var/www/html/wp-content/plugins/stream-src/classes/class-connector.php:127
/var/www/html/wp-includes/class-wp-hook.php:287
/var/www/html/wp-includes/class-wp-hook.php:311
/var/www/html/wp-includes/plugin.php:484
/var/www/html/wp-includes/post.php:4902
/var/www/html/wp-includes/post.php:4209
/var/www/html/wp-includes/post.php:4411
/var/www/html/wp-content/plugins/stream-src/tests/tests/connectors/test-class-connector-posts.php:374

Do you know which pull request introduced this? Should we fix it now or can we do it post release?

Kaspars Dambis and others added 2 commits February 11, 2021 15:47
codeclimate coverage reporter added to .travis.yml
@kasparsd kasparsd merged commit 58e2e57 into master Feb 11, 2021
@kasparsd kasparsd deleted the release/3.6.1 branch February 11, 2021 14:44
@kasparsd kasparsd mentioned this pull request Feb 12, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants