Improve PHP version checking #1212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@szepeviktor Not sure I understand the intent of this PR. How is this change an improvement? |
Contributor
Author
|
It inspects the function's return value not its negated value: one less operation, more readability. |
Contributor
Author
|
Same as pryley/site-reviews#23 |
kidunot89
approved these changes
Dec 30, 2020
kasparsd
approved these changes
Jan 4, 2021
| */ | ||
|
|
||
| if ( ! version_compare( PHP_VERSION, '5.3', '>=' ) ) { | ||
| if ( version_compare( PHP_VERSION, '5.3', '<' ) ) { |
Contributor
There was a problem hiding this comment.
I personally find the non-negative checks more readable so this looks like a useful change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just 1 line.
Checklist
contributing.md).