Skip to content

Conversation

@szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Dec 29, 2020

Fix namespace of Closure

Checklist

  • Project documentation has been updated to reflect the changes in this pull request, if applicable.
  • I have tested the changes in the local development environment (see contributing.md).
  • I have added phpunit tests.

Please consider using @phpstan

Copy link
Contributor

@kidunot89 kidunot89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szepeviktor Good catch 👍

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Dec 30, 2020

@szepeviktor Good catch 👍

@phpstan is the catcher!

@szepeviktor
Copy link
Contributor Author

composer require --ignore-platform-reqs --dev szepeviktor/phpstan-wordpress
vendor/bin/phpstan analyse -c vendor/szepeviktor/phpstan-wordpress/extension.neon alerts/ classes/ connectors/ exporters/ includes/ stream.php -l 0

Levels go up to 8!

@kasparsd
Copy link
Contributor

kasparsd commented Jan 4, 2021

@kidunot89 Feel free to merge this whenever you're around.

@kidunot89 kidunot89 added this to the 3.6.1 milestone Jan 4, 2021
@kidunot89 kidunot89 merged commit 2aa1ee3 into xwp:develop Jan 5, 2021
@szepeviktor szepeviktor deleted the patch-4 branch January 5, 2021 22:16
@kidunot89 kidunot89 mentioned this pull request Jan 12, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants