-
Notifications
You must be signed in to change notification settings - Fork 117
Blog connector test implemented and connector updated. #1177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 'deleted' | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dero @johnbillion This callback was added to resolve #1175. Please take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kidunot89 -- this callback will add an appropriate log entry, but AFAICT won't prevent the related "User removed" etc. entries from being logged, which can really clutter the log when a blog with dozens of users is removed.
I'm OK approving this PR as is, but I think we should keep #1175 open until we're able to bundle up those excessive individual log entries somehow. I'm thinking perhaps we find a way to just log "XYZ users were removed from the ABC site."?
What do you guys think?
dero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kidunot89 Good work here, thanks!
One question related to #1175
| 'deleted' | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kidunot89 -- this callback will add an appropriate log entry, but AFAICT won't prevent the related "User removed" etc. entries from being logged, which can really clutter the log when a blog with dozens of users is removed.
I'm OK approving this PR as is, but I think we should keep #1175 open until we're able to bundle up those excessive individual log entries somehow. I'm thinking perhaps we find a way to just log "XYZ users were removed from the ABC site."?
What do you guys think?
fc59f8b to
ad7a424
Compare
ad7a424 to
532ea36
Compare
Works towards #1093 .
Fixes #1175
Fixes #1187
Summary checklist
wpmu_new_blogcallback replaced withwp_initialize_sitecallback due to the deprecation of thewpmu_new_bloghook.wp_initialize_sitecallback tested and passing.wp_delete_sitecallback implemented, testing and passing.wpmu_activate_blogcallback tested and passing.add_user_to_blogcallback tested and passing.remove_user_from_blogcallback tested and passing.update_blog statusfunction and all connected hooks tested and passing.@dero @kasparsd I updated the Blog connector log meta with more info. It know include the the blog
name,url, andid.