Automatically tag releases in the distribution repository #1163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> error: src refspec 3.5.1 matches more than one https://travis-ci.com/github/xwp/stream/jobs/372078948#L474
kidunot89
changed the title
dero
reviewed
Sep 14, 2020
Contributor
dero
left a comment
dero
left a comment
There was a problem hiding this comment.
Adding a question here, @kidunot89.
kasparsd
changed the title
…/release-tagging # Conflicts: # local/scripts/dist.sh
kasparsd
reviewed
Oct 14, 2020
| if [ -n "$DIST_TAG" ]; then | ||
| echo "Tagging a release: $DIST_TAG" | ||
| git tag --force "$DIST_TAG" | ||
| git push --force --set-upstream origin --tags |
Contributor
There was a problem hiding this comment.
@dero I think the issue was caused by the $DIST_BRANCH being used together with the --tags flag. Now it will force-push all tags or just the specific branch.
I've tested this locally and it appears to be working as expected. Since this particular file isn't included in the release bundle I suggest we merge this in and test during the next release.
dero
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1157.
Summary
Add
git push --delete origin "$DIST_TAG"statement after new tag creation in the distribution script to bypass the tag naming conflict during finalgit push ...call.@kasparsd Not sure how to test this. 🤷♂️