Conversation
Sync master -> develop
* Remove redundant field in Event type * Remove redundant field in team Event type * Remove redundant federation Event module Co-authored-by: Stefan Matting <stefan@wire.com>
Noteworthy things: - I servantified `POST /i/users` because it had pretty much the same API and was using the same types. - While registering a user into a team, if the team has legal hold, the user can only be added if the fanoutLimit has not been reached. This check happens in galley, which generates a `Wai.Error`, brig just throws this error and so isn't aware of internals. This kind of error cannot be transformed into and `ErrorDescription`. So, for now (until galley's internal API is servantiified), brig throws this error using `throwM`, this error gets caught and handled by the `Handler` monad when it executes requests. This is of course not ideal. But hopefully we get to servantify Galley's internal endpoints and we can get rid of this hack. - The parser for `NewUser` is fairly complex some fields depend on other fields. To help with this, I created `NewUserRaw` which just parses individual fields. The schema for `NewUser` type uses `withParser` to do the validation and make composite fields. - Remove ToJSON/FromJSON for UserIdentity, use Schema for User. The ToJSON for UserIdentity encoded nulls, but every other object which used it didn't encode nulls. So, it was better to remove it. Co-authored-by: Matthias Fischmann <mf@zerobuzz.net>
* Clean up `Base64ByteString` - Add a strict version and make it the default - Clean up instances - Export an unnamed schema for the raw underlying 'ByteString' - Add '*HttpApi' instances using `base64url` * Add ToParamSchema instances to base64 newtypes
* Add qualified broadcast endpoint * Refactor broadcast tests This uses a record to organise arguments for the helper function. * Add qualified broadcast tests * Fix mismatch assertions in broadcast tests * Generalise broadcast route in nginz configuration * Add release note entry * Restore authentication for broadcast in demo nginz * Remove redundant use of `runLocalInput` * Rename broadcast tests
* MLS message deserialisation * Add simple message unit test * Add application message unit test * Implement welcome message deserialisation
* use assetkey type in imageasset * fix build integration tests * moved cql instance for assetkey * changelog * tweak changelog. * asset key cql instance handle invalid keys in db * comment * use Icon/AssetKey in team and user profile (wire-api changes only) * Cassandra Icon instance * fix integration test * fix galley integration tests * fix spar integration tests * format Co-authored-by: Matthias Fischmann <mf@zerobuzz.net>
* Add test for additional api-version info * Comment about /access having to be unversioned
* More spar tests. * Fix: scim user import (`getUser`). * Fix: scim user import (`getUsers`).
* Remove trailing whitespace. * Tweak wording. * Update docs/reference/config-options.md
fisx
force-pushed
the
release_2022-03-07_12_13
branch
from
2088d6f to
d69a494
Compare
akshaymankar
requested changes
Mar 7, 2022
Member
There was a problem hiding this comment.
Looks like you removed a commit and force-pushed to the release branch. If we merge this into master, it will make master diverge from develop in an annoying way where same work exists in two separate commits on master and develop. Can you please instead revert the commit on develop and then create a release PR?
fisx
force-pushed
the
release_2022-03-07_12_13
branch
from
d69a494 to
2559752
Compare
akshaymankar
approved these changes
Mar 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[2022-03-07]
Release notes
API changes
Bug fixes and other updates
Internal changes
Add tests for additional information returned by
GET /api-version(Follow-up to/api-versionchanges #2159)Clean up
Base64ByteStringimplementation (Base64 cleanup #2170)The
Eventrecord type does not contain atypefield anymore (Cleanup of event record types #2160)Add MLS message types and corresponding deserialisers (MLS Message types #2145)
Servantify
POST /registerandPOST /i/usersendpoints (Brig: ServantifyPOST /registerandPOST /i/usersendpoint #2121)