Conversation
6ae2d14 to
631e529
Compare
9e4c77d to
3e46af1
Compare
8d240f8 to
39c8741
Compare
b3fbf66 to
cebb3a1
Compare
There was a problem hiding this comment.
This looks great!
Many of the data types you introduce in this PR have fields of Word* types. Would it make sense to wrap them with newtypes? If so, I would find such an alternative easier to read: once parsed, I don't care how many bytes something was in its serialised form, and on the other hand a solid type name might suggest what it is for, and it makes it harder to confuse values of the same Word* type.
I think it would just add a lot of noise with not that many benefits, in this case. |
This PR implements deserialisation for MLS message types
Checklist
changelog.d.