Skip to content

fix setDefaultUserLocale mapping#2179

Merged
fisx merged 1 commit intodevelopfrom
fix-setDefaultUserLocale-mapping
Mar 7, 2022
Merged

fix setDefaultUserLocale mapping#2179
fisx merged 1 commit intodevelopfrom
fix-setDefaultUserLocale-mapping

Conversation

@battermann
Copy link
Contributor

@battermann battermann commented Mar 7, 2022 •
edited
Loading

setDefaultUserLocale is optional. Therefore, we need to ignore if not provided when generating the config.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect.

@battermann battermann requested review from fisx and jschaul March 7, 2022 08:56
fisx
fisx approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if this would work with missing .setDefaultUserLocale, I can't see how this change could hurt! 👍

@fisx fisx merged commit 9725e0d into develop Mar 7, 2022
@fisx fisx deleted the fix-setDefaultUserLocale-mapping branch March 7, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fisx fisx fisx approved these changes

@jschaul jschaul Awaiting requested review from jschaul

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@battermann @fisx