Skip to content

Add qualified broadcast endpoint#2166

Merged
pcapriotti merged 12 commits intodevelopfrom
pcapriotti/broadcast-qualified
Mar 3, 2022
Merged

Add qualified broadcast endpoint#2166
pcapriotti merged 12 commits intodevelopfrom
pcapriotti/broadcast-qualified

Conversation

@pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Mar 1, 2022

This adds a qualified version of the message broadcast endpoint, with the same API as the one for normal messages. This makes it possible for the clients to uniformly use the qualified API for all possible message types.

Tracked by https://wearezeta.atlassian.net/browse/SQCORE-1257.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If HTTP endpoint paths have been added or renamed, the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

Copy link
Contributor

@mdimjasevic mdimjasevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving, but before merging please take a look at the comment on changing [(UserId, (ClientId, Text)] to [(UserId, ClientId, Text)].

@pcapriotti pcapriotti merged commit a55abd7 into develop Mar 3, 2022
@pcapriotti pcapriotti deleted the pcapriotti/broadcast-qualified branch March 3, 2022 16:49
@zebot zebot mentioned this pull request Mar 7, 2022
@zebot zebot mentioned this pull request Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants