Conversation
fisx
force-pushed
the
more-spar-tests
branch
8 times, most recently
from
1521f5e to
3bc0a98
Compare
supersven
approved these changes
Mar 7, 2022
Contributor
supersven
left a comment
supersven
left a comment
There was a problem hiding this comment.
The comments are optional and may be solved with another PR.
| lift $ ST.runValidExternalId (validateEmailIfExists buid) (\_ -> pure ()) veid | ||
|
|
||
| -- {suspension via scim: if we don't reach the following line, the user will be active.} | ||
| -- TODO: suspension via scim is brittle, and may leave active users behind: if we don't |
Contributor
There was a problem hiding this comment.
Is this TODO or FUTUREWORK? If it's a TODO we should do it, don't we? Otherwise, leave it for the future us and see, if this is really an issue.
| -- lookup in that table either, but compute the `externalId` from the `UserRef`. | ||
| createValidScimUserSpar :: | ||
| forall m r. | ||
| ( (m ~ Scim.ScimHandler (Sem r)), |
Contributor
There was a problem hiding this comment.
I'm wondering if can't just inline m as it's only used in line 504. 🤔
| specImportToScimFromInvitation :: SpecWith TestEnv | ||
| specImportToScimFromInvitation = | ||
| describe "Create with TM invitation; then re-provision with SCIM" $ do | ||
| check True |
Contributor
There was a problem hiding this comment.
"Boolean blindness". Probably, this would be more readable with a dedicated type.
| tenant = idp ^. SAML.idpMetadata . SAML.edIssuer | ||
| void $ createViaSaml idp privCreds uref | ||
|
|
||
| check :: Bool -> SpecWith TestEnv |
Contributor
There was a problem hiding this comment.
One could order the functions by call time (hierarchy).
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/CS-742
With the tests in this PR, but without the changes, I get this error:
The changes in the later commits fix this. The problem was that under certain conditions, spar did not create SAML credentials during SCIM provisioning.
Checklist
changelog.d.